Skip to content

[TEST CI] Do not call urDeviceRetain() in device_impl ctor at all #20144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[TEST CI] Do not call urDeviceRetain() in device_impl ctor at all #20144

wants to merge 1 commit into from

Conversation

@ldorau
Copy link
Contributor

@ldorau ldorau commented Sep 22, 2025

No description provided.

@ldorau ldorau mentioned this pull request Sep 22, 2025
Closed
@ldorau ldorau force-pushed the Do_not_call_urDeviceRetain_in_device_impl_ctor_at_all branch from bc8a3f8 to e4cd401 Compare September 22, 2025 11:58
@ldorau ldorau force-pushed the Do_not_call_urDeviceRetain_in_device_impl_ctor_at_all branch from e4cd401 to e40f5b2 Compare September 22, 2025 19:57
@ldorau
[SYCL][UR] Do not call urDeviceRetain() in device_impl ctor at all
e40f5b2 
urDeviceRetain(MDevice) should not be called in device_impl ctor at all,
because RefCounter is initialized with 1, when the device is created.

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau closed this Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ldorau